Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-4996: Permission based commit filtering #984

Merged
merged 15 commits into from
Mar 1, 2022

Conversation

AAAlinaaa
Copy link
Contributor

No description provided.

@AAAlinaaa AAAlinaaa self-assigned this Feb 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #984 (cef4832) into 8.x (fd56483) will increase coverage by 0.25%.
The diff coverage is 91.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##                8.x     #984      +/-   ##
============================================
+ Coverage     64.60%   64.85%   +0.25%     
- Complexity    11878    11945      +67     
============================================
  Files          1689     1689              
  Lines         55551    55618      +67     
  Branches       5152     5159       +7     
============================================
+ Hits          35887    36070     +183     
+ Misses        17469    17347     -122     
- Partials       2195     2201       +6     
Impacted Files Coverage Δ
...l/snowowl/core/commit/CommitInfoSearchRequest.java 85.24% <91.17%> (+85.24%) ⬆️
.../snomed/core/ecl/SnomedEclRefinementEvaluator.java 85.67% <0.00%> (-0.28%) ⬇️
...ational/index/query/AbstractExpressionBuilder.java 93.47% <0.00%> (+0.14%) ⬆️
.../b2international/index/es/client/EsClientBase.java 65.90% <0.00%> (+1.13%) ⬆️
...onal/snowowl/snomed/core/tree/TerminologyTree.java 87.75% <0.00%> (+2.04%) ⬆️
...national/snowowl/core/locks/OperationLockInfo.java 46.66% <0.00%> (+3.33%) ⬆️
...src/com/b2international/index/revision/Commit.java 61.64% <0.00%> (+4.10%) ⬆️
...al/snowowl/core/request/BaseResourceConverter.java 95.23% <0.00%> (+4.76%) ⬆️
...owl/core/identity/AuthorizationHeaderVerifier.java 60.00% <0.00%> (+5.71%) ⬆️
...al/snowowl/core/repository/RepositoryRequests.java 33.33% <0.00%> (+11.11%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd56483...cef4832. Read the comment docs.

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmark cmark merged commit 056fb7a into 8.x Mar 1, 2022
@cmark cmark deleted the issue/SO-4996-permission_based_commit_filtering branch March 1, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants